Update THV-0057 key format to prevent cross-type collisions#69
Merged
Conversation
Per-user per-operation Redis keys now use distinct prefixes
(user-tool:, user-prompt:, user-resource:) instead of nesting
under user:{userId}:tool:... to prevent key collisions when a
userId contains delimiter characters like ":tool:".
The operation name precedes the userId so that the variable-length
userId is always the terminal key component.
Matches the implementation shipped in stacklok/toolhive#4692.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jhrozek
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The implementation of per-user rate limiting (stacklok/toolhive#4692) revealed that the RFC's Redis key format for per-user per-operation keys could produce collisions when a
userIdcontains delimiter characters like:tool:.user-tool:,user-prompt:,user-resource:) instead of nesting underuser:{userId}:tool:...The original format
user:{userId}:tool:{toolName}collides with server-leveluser:{userId}when a userId literally contains:tool:{toolName}. While unlikely in practice (JWTsubclaims are typically UUIDs or emails), the distinct prefix approach eliminates the structural ambiguity entirely.Generated with Claude Code